From 55660b91440904d69a030a71de302d910f3f13b2 Mon Sep 17 00:00:00 2001 From: Laria Carolin Chabowski Date: Sun, 4 Oct 2020 14:29:17 +0200 Subject: Fix crashing when an action is performed without a focussed editor Turns out checking for a focussed editor in update() is not enough, because you can invoke the action, even if it's marked as inactive. Checking again in actionPerformed() fixes the issue. --- .../java/me/laria/code/idea_caseconv/SelectionReplacerAction.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/main/java/me/laria/code') diff --git a/src/main/java/me/laria/code/idea_caseconv/SelectionReplacerAction.java b/src/main/java/me/laria/code/idea_caseconv/SelectionReplacerAction.java index 088a1e2..d715ac2 100644 --- a/src/main/java/me/laria/code/idea_caseconv/SelectionReplacerAction.java +++ b/src/main/java/me/laria/code/idea_caseconv/SelectionReplacerAction.java @@ -33,8 +33,10 @@ abstract class SelectionReplacerAction extends AnAction { public void actionPerformed(AnActionEvent anActionEvent) { Editor editor = anActionEvent.getData(CommonDataKeys.EDITOR); Project project = anActionEvent.getData(CommonDataKeys.PROJECT); - assert editor != null; - assert project != null; + + if (editor == null || project == null) { + return; + } CaretModel caretModel = editor.getCaretModel(); Document document = editor.getDocument(); -- cgit v1.2.3-54-g00ecf